Changeset 8 for src/main/java/geniusweb/partiesserver/websocket/PartySocket.java

Timestamp:

11/28/19 14:41:10 (5 years ago)

Author:

bart

Message:

Release 1.1.0

File:

• src/main/java/geniusweb/partiesserver/websocket/PartySocket.java (modified) (7 diffs)

src/main/java/geniusweb/partiesserver/websocket/PartySocket.java

@@ -5 +5 @@
 import java.net.URI;
 import java.util.Date;
+import java.util.List;
+import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.logging.Level;
 
@@ -23 +25 @@
 import geniusweb.actions.Action;
 import geniusweb.actions.PartyId;
-import geniusweb.connection.DefaultConnection;
+import geniusweb.connection.ConnectionEnd;
 import geniusweb.partiesserver.repository.RunningPartiesRepo;
 import geniusweb.partiesserver.repository.RunningParty;
 import geniusweb.party.Party;
-import geniusweb.party.inform.Finished;
 import geniusweb.party.inform.Inform;
 import geniusweb.party.inform.Settings;
@@ -41 +42 @@
  */
 @ServerEndpoint("/party/{party}")
-public class PartySocket extends DefaultConnection<Inform, Action> {
+public class PartySocket implements ConnectionEnd<Inform, Action> {
         private final static ObjectMapper jackson = new ObjectMapper();
         private final Reporter log;
         private final RunningPartiesRepo runningparties;
+        private final List<Listener<Inform>> listeners = new CopyOnWriteArrayList<Listener<Inform>>();
 
         // should all be final, except that we can only set them when start is
@@ -86 +88 @@
                                                 runningparties.removeListener(this);
                                                 session.close(new CloseReason(CloseCodes.GOING_AWAY,
-                                                                "party died"));
+                                                                "detected that party vanished"));
                                         } catch (IOException e) {
                                                 log.log(Level.WARNING,
@@ -131 +133 @@
                                 party.inform(info);
                         } catch (Throwable e) {
-                                // simple sandbox
-                                log.log(Level.WARNING, "Party failed on inform:", e);
+                                log.log(Level.WARNING, "Party failed on inform.", e);
+                                // we don't use jackson.writeValueAsString(e) here because
+                                // CloseReason has 123 char limit.
+                                // The error will be too large to fit and will be truncated
+                                // therefore we send a plain string and hope that enough
+                                // will arrive at the other side (the protocol)
+                                session.close(new CloseReason(
+                                                CloseReason.CloseCodes.CLOSED_ABNORMALLY,
+                                                "party threw exception: " + collectReasons(e)));
                         }
-                } // else dead but that's handled in the listener above
+                } // else party is dead but that's handled in the listener above
+        }
+
+        /**
+         * 
+         * @param e an exception
+         * @return collect all reasons and sub-reasons
+         */
+        private String collectReasons(Throwable e) {
+                String reason = "";
+                do {
+                        reason = reason + " : " + e.getClass().getSimpleName() + ":"
+                                        + e.getMessage();
+                        e = e.getCause();
+                } while (e != null);
+                return reason;
         }
 
@@ -145 +169 @@
          */
         private void sniff(Inform info, RunningParty party) throws IOException {
-                if (info instanceof Finished) {
-                        session.close(new CloseReason(CloseCodes.GOING_AWAY,
-                                        "session reached agreement"));
-                } else if (info instanceof Settings) {
+                // do NOT sniff Finished messages and close sockets. Parties and their
+                // sockets need to stay running till all messages are handled
+                if (info instanceof Settings) {
                         Date end = ((Settings) info).getProgress().getTerminationTime();
                         runningparties.replace(party.withEndTime(end));
@@ -209 +232 @@
         }
 
+        @Override
+        public void addListener(Listener<Inform> l) {
+                listeners.add(l);
+        }
+
+        @Override
+        public void removeListener(Listener<Inform> l) {
+                listeners.remove(l);
+        }
+
+        /**
+         * This should only be called by the owner of the listenable, not by
+         * listeners or others. Avoid calling this from synchronized blocks as a
+         * notified listener might immediately make more calls to you.
+         * <p>
+         * Any listeners that throw an exception will be intercepted and their
+         * stacktrace is printed.
+         * 
+         * @param data information about the change.
+         */
+        public void notifyListeners(Inform data) {
+                for (Listener<Inform> l : listeners) {
+                        l.notifyChange(data);
+                }
+        }
+
 }