Changeset 53 for profile/src/main/java/geniusweb/profile/utilityspace/PartsUtilities.java

Timestamp:

12/18/24 13:28:59 (4 days ago)

Author:

ruud

Message:

All TimeDependent parties now support the nonlinear SumOfGroupsUtilitySpace. Example Nonlinear space in the computer domain

File:

• profile/src/main/java/geniusweb/profile/utilityspace/PartsUtilities.java (modified) (6 diffs)

profile/src/main/java/geniusweb/profile/utilityspace/PartsUtilities.java

@@ -7 +7 @@
 import java.util.List;
 import java.util.Map;
+import java.util.stream.Collectors;
 
 import com.fasterxml.jackson.annotation.JsonAutoDetect;
@@ -13 +14 @@
 import com.fasterxml.jackson.annotation.JsonProperty;
 
+import geniusweb.issuevalue.Domain;
 import geniusweb.issuevalue.Value;
 import geniusweb.issuevalue.ValueSet;
+import tudelft.utilities.immutablelist.ImmutableList;
+import tudelft.utilities.immutablelist.Outer;
 
 /**
@@ -41 +45 @@
          * 
          * @param issues list of issues
-         * @param utils  with keys: list of values and value: utility value for that
-         *               list of values. All list-of-values missing from the map are
-         *               assumed to have utility 0. This includes partial bids where
-         *               list-of-values contain null objects.
+         * @param utils  with keys: list of values, one for each issue in issues (in
+         *               the order of the list of issues) and value: utility value
+         *               for that list of values. All list-of-values missing from
+         *               the map are assumed to have utility 0. This includes
+         *               partial bids where list-of-values contain null objects.
          */
         public PartsUtilities(List<String> issues,
                         Map<ProductOfValue, BigDecimal> utils) {
-                if (issues == null || utils == null) {
+                if (issues == null || utils == null || issues.isEmpty()) {
                         throw new IllegalArgumentException(
-                                        "issues and utils must be not null");
+                                        "issues and utils must be not null or empty");
                 }
 
@@ -149 +154 @@
         }
 
+        /**
+         * Check that all needed values have been set to a utility.
+         * 
+         * @param domain the domain for which this should be parts. We need this to
+         *               check that the values used are actually from the dmoain
+         * @throws IllegalArgumentException if a problem is found
+         */
+        public void checkComplete(Domain domain) {
+
+                final List<ImmutableList<Value>> valuesofissues = issues.stream()
+                                .map(iss -> domain.getValues(iss)).collect(Collectors.toList());
+
+                // check that all possible value combinations are handled
+                for (ImmutableList<Value> vals : new Outer<Value>(valuesofissues)) {
+                        ProductOfValue expected = ProductOfValue.create(vals);
+                        if (!utilities.containsKey(expected))
+                                throw new IllegalArgumentException(
+                                                "Values " + vals + " must be assigned a utility");
+                }
+        }
+
         @Override
         public boolean equals(Object obj) {
@@ -176 +202 @@
         }
 
+        /**
+         * Check that the set of utilities is complete and no weird utility values
+         * were used
+         * 
+         */
         private void checkUtilities() {
-                if (utilities.values().stream()
-                                .anyMatch(v -> v == null || v.compareTo(BigDecimal.ZERO) < 0
-                                                || v.compareTo(BigDecimal.ONE) > 0)) {
-                        throw new IllegalArgumentException(
-                                        "part weights must all be in [0,1]");
+                for (BigDecimal value : utilities.values()) {
+                        if (value == null || value.compareTo(BigDecimal.ZERO) < 0
+                                        || value.compareTo(BigDecimal.ONE) > 0)
+                                throw new IllegalArgumentException(
+                                                "part weights must all be in [0,1] but found " + value);
                 }
         }
@@ -196 +227 @@
 
         /**
-         * 
          * @return the max utility of all values contained here.
          */