Changeset 5

Timestamp:

09/24/19 14:13:25 (5 years ago)

Author:

bart

Message:

Fixed performance issue with some computers

Files:

• pom.xml (modified) (2 diffs)
• src/main/java/geniusweb/partiesserver/websocket/PartiesListSocket.java (modified) (2 diffs)
• src/main/webapp/index.jsp (modified) (1 diff)

pom.xml

@@ -276 +276 @@
                                 <groupId>org.apache.maven.plugins</groupId>
                                 <artifactId>maven-dependency-plugin</artifactId>
-                                <version>3.1.1</version>
+                                <!--  leave out version to help Eclipse workaround -->
                                 <executions>
                                         <execution>
@@ -346 +346 @@
                                 <groupId>org.apache.maven.plugins</groupId>
                                 <artifactId>maven-assembly-plugin</artifactId>
-                                <version>2.4.1</version>
+                                <!--  leave out version to help Eclipse workaround -->
                                 <configuration>
                                         <!-- get all project dependencies -->

src/main/java/geniusweb/partiesserver/websocket/PartiesListSocket.java

@@ -46 +46 @@
         private AvailablePartiesRepo repo;
         private SendBuffer outstream;
+        private static transient String hostport = ""; // cache
 
         public PartiesListSocket() {
@@ -140 +141 @@
         private String getIpAddressAndPort()
                         throws UnknownHostException, MalformedObjectNameException {
+                synchronized (hostport) {
+                        if (hostport.isEmpty()) {
+                                MBeanServer beanServer = ManagementFactory
+                                                .getPlatformMBeanServer();
 
-                MBeanServer beanServer = ManagementFactory.getPlatformMBeanServer();
+                                Set<ObjectName> objectNames = beanServer.queryNames(
+                                                new ObjectName("*:type=Connector,*"),
+                                                Query.match(Query.attr("protocol"),
+                                                                Query.value("HTTP/1.1")));
 
-                Set<ObjectName> objectNames = beanServer.queryNames(
-                                new ObjectName("*:type=Connector,*"),
-                                Query.match(Query.attr("protocol"), Query.value("HTTP/1.1")));
+                                String host = InetAddress.getLocalHost().getHostAddress();
+                                String port = objectNames.iterator().next()
+                                                .getKeyProperty("port");
 
-                String host = InetAddress.getLocalHost().getHostAddress();
-                String port = objectNames.iterator().next().getKeyProperty("port");
-
-                return host + ":" + port;
+                                hostport = host + ":" + port;
+                        }
+                        return hostport;
+                }
 
         }

src/main/webapp/index.jsp

@@ -18 +18 @@
         Notice that these may contain files
         with errors, and thus are not available for use (and not appear on the parties list).
-
-        <h2>Adding / Removing party classes</h2>
-        You can add and remove parties by dragging your jar files into and
-        out of the <code>partiesserver/partiesrepo</code> directory. This directory is inside the 
-        tomcat directory which is created when the partiesserver is
-        started the first time. Changed, new or removed files are recognised automatically by the server and made available. 
-        Be careful when you change this as this may disturb currently running sessions and tournaments.
-        <br>
-        For making or compiling new parties, please refer to the <a href="https://tracinsy.ewi.tudelft.nl/pubtrac/GeniusWeb"> GeniusWeb main page</a>. 
+<p>
+        For help and more info, please refer to the <a href="https://tracinsy.ewi.tudelft.nl/pubtrac/GeniusWebPartiesServer"> parties server page</a>.