Changeset 24 for exampleparties/humangui

Timestamp:

10/06/20 13:12:20 (4 years ago)

Author:

bart

Message:

Fixes an issue with processing maxPower of a vote. Javadoc maven plugin now uses latest version.

Location:

exampleparties/humangui

Files:

• pom.xml (modified) (4 diffs)
• src/main/java/geniusweb/exampleparties/humangui/BiddingInfo.java (modified) (3 diffs)
• src/test/java/geniusweb/exampleparties/humangui/HumanGuiTest.java (modified) (3 diffs)

exampleparties/humangui/pom.xml

@@ -6 +6 @@
         <groupId>geniusweb.exampleparties</groupId>
         <artifactId>humangui</artifactId>
-        <version>1.5.2</version> <!-- must equal ${geniusweb.version} -->
+        <version>1.5.3</version> <!-- must equal ${geniusweb.version} -->
         <packaging>jar</packaging>
 
@@ -17 +17 @@
                 <passwd>${env.ARTIFACTORY_PASS}</passwd>
                 <jackson-2-version>2.9.6</jackson-2-version>
-                <geniusweb.version>1.5.2</geniusweb.version>
+                <geniusweb.version>1.5.3</geniusweb.version>
         </properties>
 
@@ -182 +182 @@
                                 <groupId>org.apache.maven.plugins</groupId>
                                 <artifactId>maven-javadoc-plugin</artifactId>
-                                <version>2.10.1</version>
+                                <version>3.2.0</version>
                                 <executions>
                                         <execution>
@@ -189 +189 @@
                                                         <goal>jar</goal>
                                                 </goals>
-                                                <configuration>
-                                                        <additionalparam>${javadoc.opts}</additionalparam>
-                                                        <additionalparam>-Xdoclint:none</additionalparam>
-                                                </configuration>
                                         </execution>
                                 </executions>

exampleparties/humangui/src/main/java/geniusweb/exampleparties/humangui/BiddingInfo.java

@@ -32 +32 @@
  * <li>{@link Bid} if user changed his prepared bid (but did not yet offer it)
  * <li>{@link Profile} if the profile was changed
- * <li>{@Link Boolean} if the isMyTurn value changed.
+ * <li>{@link Boolean} if the isMyTurn value changed.
  * </ul>
  */
@@ -57 +57 @@
          * @param reporter   the {@link Reporter} where we can log issues.
          * @param profileint the {@link ProfileInterface}
-         * @throws Exception if we can not reach the protocol server
+         * @throws IOException         if we can not reach the protocol server
+         * @throws DeploymentException if we can not reach the protocol server
          */
         public BiddingInfo(Settings settings,
@@ -97 +98 @@
          * 
          * @param action the action to execute.
-         * @throws IOException           if action can not be sent.
-         * @throws IllegalStateException if isMyTurn is false.
          */
         public void doAction(Action action) {

exampleparties/humangui/src/test/java/geniusweb/exampleparties/humangui/HumanGuiTest.java

@@ -6 +6 @@
 import static org.junit.Assert.assertTrue;
 import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
 
 import java.io.IOException;
@@ -28 +29 @@
 import geniusweb.bidspace.AllBidsList;
 import geniusweb.inform.ActionDone;
+import geniusweb.inform.Agreements;
 import geniusweb.inform.Finished;
 import geniusweb.inform.Settings;
@@ -76 +78 @@
         @After
         public void after() {
-                party.notifyChange(new Finished(null));
+                Agreements agreements = mock(Agreements.class);
+                when(agreements.toString()).thenReturn("agree");
+                party.notifyChange(new Finished(agreements));
         }