Changeset 24 for exampleparties/anac2019/agentgg

Timestamp:

10/06/20 13:12:20 (4 years ago)

Author:

bart

Message:

Fixes an issue with processing maxPower of a vote. Javadoc maven plugin now uses latest version.

Location:

exampleparties/anac2019/agentgg

Files:

• pom.xml (modified) (4 diffs)
• src/main/java/geniusweb/exampleparties/agentgg/ImpMap.java (modified) (2 diffs)
• src/main/java/geniusweb/exampleparties/agentgg/SimpleLinearOrdering.java (modified) (1 diff)
• src/test/java/geniusweb/exampleparties/agentgg/AgentGGTest.java (modified) (2 diffs)

exampleparties/anac2019/agentgg/pom.xml

@@ -6 +6 @@
         <groupId>geniusweb.exampleparties.anac2019</groupId>
         <artifactId>agentgg</artifactId>
-        <version>1.5.2</version> <!-- must equal ${geniusweb.version} -->
+        <version>1.5.3</version> <!-- must equal ${geniusweb.version} -->
         <packaging>jar</packaging>
 
@@ -17 +17 @@
                 <passwd>${env.ARTIFACTORY_PASS}</passwd>
                 <jackson-2-version>2.9.6</jackson-2-version>
-                <geniusweb.version>1.5.2</geniusweb.version>
+                <geniusweb.version>1.5.3</geniusweb.version>
         </properties>
 
@@ -192 +192 @@
                                 <groupId>org.apache.maven.plugins</groupId>
                                 <artifactId>maven-javadoc-plugin</artifactId>
-                                <version>2.10.1</version>
+                                <version>3.2.0</version>
                                 <executions>
                                         <execution>
@@ -199 +199 @@
                                                         <goal>jar</goal>
                                                 </goals>
-                                                <configuration>
-                                                        <additionalparam>${javadoc.opts}</additionalparam>
-                                                        <additionalparam>-Xdoclint:none</additionalparam>
-                                                </configuration>
                                         </execution>
                                 </executions>

exampleparties/anac2019/agentgg/src/main/java/geniusweb/exampleparties/agentgg/ImpMap.java

@@ -63 +63 @@
          * "weight sum" and "number of times" in the import table.
          * 
-         * @param bids a list of ordered bids, worst bid first, best bid last
+         * @param bidOrdering a list of ordered bids, worst bid first, best bid last
          */
         public void self_update(List<Bid> bidOrdering) {
@@ -116 +116 @@
          * @param bid the bid to get the importance (utility?) of.
          * @return the importance value of bid. Note, this this returns possibly
-         *         large (>1) values, as the importance is not normalized.
+         *         large (&gt;1) values, as the importance is not normalized.
          */
         public double getImportance(Bid bid) {

exampleparties/anac2019/agentgg/src/main/java/geniusweb/exampleparties/agentgg/SimpleLinearOrdering.java

@@ -67 +67 @@
         /**
          * 
-         * @param bid
+         * @param bid a {@link Bid}
          * @return true iff bid is contained in this ordering
          */

exampleparties/anac2019/agentgg/src/test/java/geniusweb/exampleparties/agentgg/AgentGGTest.java

@@ -35 +35 @@
 import geniusweb.connection.ConnectionEnd;
 import geniusweb.inform.ActionDone;
+import geniusweb.inform.Agreements;
 import geniusweb.inform.Finished;
 import geniusweb.inform.Inform;
@@ -180 +181 @@
                 party.connect(connection);
                 party.notifyChange(settings);
-                party.notifyChange(new Finished(null));
+
+                Agreements agreements = mock(Agreements.class);
+                when(agreements.toString()).thenReturn("agree");
+                party.notifyChange(new Finished(agreements));
 
                 verify(reporter).log(eq(Level.INFO),
-                                eq("Final ourcome:Finished[null]"));
+                                eq("Final ourcome:Finished[agree]"));
         }