Changeset 19 for exampleparties/anac2019/agentgg/src

Timestamp:

06/22/20 16:08:04 (4 years ago)

Author:

bart

Message:

Tries harder to kill parties after deadline

Location:

exampleparties/anac2019/agentgg/src

Files:

• main/java/geniusweb/exampleparties/agentgg/AgentGG.java (modified) (4 diffs)
• main/java/geniusweb/exampleparties/agentgg/ImpMap.java (modified) (1 diff)
• test/java/geniusweb/exampleparties/agentgg/AgentGGTest.java (modified) (1 diff)

exampleparties/anac2019/agentgg/src/main/java/geniusweb/exampleparties/agentgg/AgentGG.java

@@ -39 +39 @@
  * Xu and Peihao Ren of University of Southampton. This party requires a partial
  * ordering as input (notice that most profiles are also partial ordering
- * anyway).
+ * anyway). Much javadoc has been added after reverse engineering, to enable the
+ * translation.
  */
 public class AgentGG extends DefaultParty {
@@ -47 +48 @@
         private double offerLowerRatio = 1.0;
         private double offerHigherRatio = 1.1;
-        private double MAX_IMPORTANCE;
-        private double MIN_IMPORTANCE;
+        protected double MAX_IMPORTANCE;
+        protected double MIN_IMPORTANCE;
         private double MEDIAN_IMPORTANCE;
         private Bid MAX_IMPORTANCE_BID;
@@ -319 +320 @@
                                         this.reservationImportanceRatio + 0.2);
                 }
+                // #1799 HACK not in original code : somethmes above computation goes
+                // wildly off bounds.
+                if (this.offerLowerRatio > 1)
+                        this.offerLowerRatio = 0.9999;
                 this.offerHigherRatio = this.offerLowerRatio + 0.1;
         }
@@ -412 +417 @@
          * the threshold range, and return the bid with the highest opponent import.
          *
-         * @param lowerRatio Generate a lower limit for the random bid
-         * @param upperRatio Generate random bid upper limit
+         * @param lowerRatio Generate a lower limit for the random bid in [0,1]
+         * @param upperRatio Generate random bid upper limit can be >1
          * @return Bid
          * @throws IOException

exampleparties/anac2019/agentgg/src/main/java/geniusweb/exampleparties/agentgg/ImpMap.java

@@ -115 +115 @@
         /**
          * @param bid the bid to get the importance (utility?) of.
-         * @return the importance value of bid. CHECK is this inside [0,1]?
+         * @return the importance value of bid. Note, this this returns possibly
+         *         large (>1) values, as the importance is not normalized.
          */
         public double getImportance(Bid bid) {

exampleparties/anac2019/agentgg/src/test/java/geniusweb/exampleparties/agentgg/AgentGGTest.java

@@ -89 +89 @@
 
         @Test
+        public void testMinMaxRealistic() {
+                assertTrue(party.MIN_IMPORTANCE >= 0);
+                assertTrue(party.MIN_IMPORTANCE < 1);
+                assertTrue(party.MAX_IMPORTANCE >= 0);
+                assertTrue(party.MAX_IMPORTANCE < 1);
+                assertTrue(party.MIN_IMPORTANCE <= party.MAX_IMPORTANCE);
+        }
+
+        @Test
         public void getDescriptionTest() {
                 assertNotNull(party.getDescription());